LGTM with comments.
https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc#newcode4864 src/objects.cc:4864: obj != heap->null_value(); While you're at it, can you replace this with !obj->IsNull()? (And likewise in a couple of places below.) https://chromiumcodereview.appspot.com/10736009/diff/1/src/objects.cc#newcode7799 src/objects.cc:7799: if (!prototype->IsJSReceiver()) { Do we still need this conditional at all? AFAICS, it is subsumed by the loop condition below. https://chromiumcodereview.appspot.com/10736009/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
