Reviewers: danno,
Message:
PTAL
Description:
Fix compile errors in Visual C++ 2008.
Without the patch I get this:
1>assembler-arm.cc
1>..\..\src\arm\assembler-arm.cc(84) : error C2220: warning treated as
error -
no 'object' file generated
1>..\..\src\arm\assembler-arm.cc(84) : warning C4244: 'initializing' :
conversion from 'uint64_t' to 'unsigned int', possible loss of data
1>..\..\src\arm\assembler-arm.cc(749) : warning C4146: unary minus operator
applied to unsigned type, result still unsigned
1>..\..\src\arm\assembler-arm.cc(757) : warning C4146: unary minus operator
applied to unsigned type, result still unsigned
[email protected]
BUG=None
TEST=ARM compiles on VC 2008.
Please review this at https://chromiumcodereview.appspot.com/10690111/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/assembler-arm.cc
Index: src/arm/assembler-arm.cc
diff --git a/src/arm/assembler-arm.cc b/src/arm/assembler-arm.cc
index
68fcc28400ce7ed29f0fda40e36dd3103a2fce3d..d875796217ddf3aa2f21c72e26bfa8bdfb320400
100644
--- a/src/arm/assembler-arm.cc
+++ b/src/arm/assembler-arm.cc
@@ -80,8 +80,8 @@ static uint64_t CpuFeaturesImpliedByCompiler() {
void CpuFeatures::Probe() {
- unsigned standard_features = (OS::CpuFeaturesImpliedByPlatform() |
- CpuFeaturesImpliedByCompiler());
+ unsigned standard_features = static_cast<unsigned>(
+ OS::CpuFeaturesImpliedByPlatform() | CpuFeaturesImpliedByCompiler());
ASSERT(supported_ == 0 || supported_ == standard_features);
#ifdef DEBUG
initialized_ = true;
@@ -746,7 +746,7 @@ static bool fits_shifter(uint32_t imm32,
}
}
} else if ((*instr & kCmpCmnMask) == kCmpCmnPattern) {
- if (fits_shifter(-imm32, rotate_imm, immed_8, NULL)) {
+ if (fits_shifter(-static_cast<int>(imm32), rotate_imm, immed_8,
NULL)) {
*instr ^= kCmpCmnFlip;
return true;
}
@@ -754,7 +754,7 @@ static bool fits_shifter(uint32_t imm32,
Instr alu_insn = (*instr & kALUMask);
if (alu_insn == ADD ||
alu_insn == SUB) {
- if (fits_shifter(-imm32, rotate_imm, immed_8, NULL)) {
+ if (fits_shifter(-static_cast<int>(imm32), rotate_imm, immed_8,
NULL)) {
*instr ^= kAddSubFlip;
return true;
}
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
