One real comment in heap.cc, the rest are just nits.
https://chromiumcodereview.appspot.com/10702168/diff/4001/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10702168/diff/4001/src/d8.cc#newcode1307 src/d8.cc:1307: "Value |\n"); Ueber-Nit: Can we have a space in front of "Value"? https://chromiumcodereview.appspot.com/10702168/diff/4001/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10702168/diff/4001/src/heap.cc#newcode7233 src/heap.cc:7233: memset(object_sizes_, 0, sizeof(object_counts_)); Better use sizeof(object_sizes_) here. https://chromiumcodereview.appspot.com/10702168/diff/4001/src/heap.cc#newcode7244 src/heap.cc:7244: counters->count_of_##name()->Increment(object_counts_[name]); \ Is there a particular reason we cannot use counter->Set() here? That would obsolete the last_time_stats tables completely. https://chromiumcodereview.appspot.com/10702168/diff/4001/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10702168/diff/4001/src/mark-compact.cc#newcode948 src/mark-compact.cc:948: class IterateAndCountBody { Can we call this class "ObjectStatsTracker" or "ObjectStatsCallthrough" or something like that? https://chromiumcodereview.appspot.com/10702168/diff/4001/src/mark-compact.cc#newcode1028 src/mark-compact.cc:1028: // Copy the table visitor table to make call-through possible. Drop the first "table". https://chromiumcodereview.appspot.com/10702168/diff/4001/src/v8-counters.h File src/v8-counters.h (right): https://chromiumcodereview.appspot.com/10702168/diff/4001/src/v8-counters.h#newcode1 src/v8-counters.h:1: // Copyright 2011 the V8 project authors. All rights reserved. 2012 https://chromiumcodereview.appspot.com/10702168/diff/4001/src/v8-counters.h#newcode34 src/v8-counters.h:34: #include "objects.h" Is it possible to alpha-sort these includes or does that cause include conflicts? https://chromiumcodereview.appspot.com/10702168/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
