LGTM with comments.
https://chromiumcodereview.appspot.com/10694157/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/10694157/diff/1/src/flag-definitions.h#newcode545 src/flag-definitions.h:545: "verify that code objects keep at most one context alive after GC") Is it one context, or one global context? https://chromiumcodereview.appspot.com/10694157/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10694157/diff/1/src/mark-compact.cc#newcode305 src/mark-compact.cc:305: EnableCodeFlushing(was_code_flushing_enabled); Please move the surrounding code into VerifyContextSeparation and add a comment explaining the main idea; why code flushing needs to be disabled; why we need to verify that the mark bits are clean etc. https://chromiumcodereview.appspot.com/10694157/diff/1/src/mark-compact.cc#newcode1669 src/mark-compact.cc:1669: ASSERT(context->IsGlobalContext()); Can this happen? https://chromiumcodereview.appspot.com/10694157/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
