I changed the CL to not turn the counters into histogram, but add
histograms for
external fragmentation of each space
PTAL
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.cc
File src/counters.cc (right):
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.cc#newcode1
src/counters.cc:1: // Copyright 2007-2008 the V8 project authors. All
rights reserved.
On 2012/07/02 21:09:56, Michael Starzinger wrote:
2012
Done.
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.cc#newcode68
src/counters.cc:68: if (Enabled())
On 2012/07/02 21:09:56, Michael Starzinger wrote:
Curly brackets if not on one line.
Done.
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.h
File src/counters.h (right):
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.h#newcode1
src/counters.h:1: // Copyright 2007-2008 the V8 project authors. All
rights reserved.
On 2012/07/02 21:09:56, Michael Starzinger wrote:
2012
Done.
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.h#newcode173
src/counters.h:173: return ptr_;
On 2012/07/02 21:09:56, Michael Starzinger wrote:
Aww, that should be on one line.
Done.
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.h#newcode202
src/counters.h:202: // Similar to StatsCounter, the class Histogram
represents a dynamically
On 2012/07/02 21:09:56, Michael Starzinger wrote:
Can we remove the reference to StatsCounter here? Just "A Histogram
represents
[...]"
Done.
https://chromiumcodereview.appspot.com/10695056/diff/1/src/counters.h#newcode220
src/counters.h:220: // Returns false if table is full.
On 2012/07/02 21:09:56, Michael Starzinger wrote:
Let's turn that into just one line: "Returns true if this histogram is
enabled."
Done.
https://chromiumcodereview.appspot.com/10695056/diff/1/src/v8-counters.h
File src/v8-counters.h (right):
https://chromiumcodereview.appspot.com/10695056/diff/1/src/v8-counters.h#newcode1
src/v8-counters.h:1: // Copyright 2011 the V8 project authors. All
rights reserved.
On 2012/07/02 21:09:56, Michael Starzinger wrote:
2012
Done.
https://chromiumcodereview.appspot.com/10695056/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
