LGTM with comments.
https://chromiumcodereview.appspot.com/10695205/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://chromiumcodereview.appspot.com/10695205/diff/1/src/arm/code-stubs-arm.cc#newcode3416 src/arm/code-stubs-arm.cc:3416: __ stm(db_w, sp, cache_entry.bit() | r2.bit() | r3.bit()); Let's use "__ Push(cache_entry, r2, r3)" instead. https://chromiumcodereview.appspot.com/10695205/diff/1/src/arm/code-stubs-arm.cc#newcode3422 src/arm/code-stubs-arm.cc:3422: __ ldm(ia_w, sp, cache_entry.bit() | r2.bit() | r3.bit()); ...and __ Pop(...) here. https://chromiumcodereview.appspot.com/10695205/diff/1/test/mjsunit/regress/regress-2234.js File test/mjsunit/regress/regress-2234.js (right): https://chromiumcodereview.appspot.com/10695205/diff/1/test/mjsunit/regress/regress-2234.js#newcode37 test/mjsunit/regress/regress-2234.js:37: test(i); I'd add: if (i == 3) %OptimizeFunctionOnNextCall(test); and don't forget // Flags: --allow-natives-syntax https://chromiumcodereview.appspot.com/10695205/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
