http://codereview.chromium.org/10785002/diff/1/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

http://codereview.chromium.org/10785002/diff/1/src/arm/simulator-arm.cc#newcode3055
src/arm/simulator-arm.cc:3055: : static_cast<int>(val);
I don't think this change is correct, as it effectively ignores the
unsigned_integer bool. I think in the unsigned case you need to cast
twice: double -> uint32_t -> int, as in:

int temp = unsigned_integer
    ? static_cast<int>(static_cast<uint32_t>(val))
    : static_cast<int>(val);

http://codereview.chromium.org/10785002/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to