Revision: 12099
Author: [email protected]
Date: Mon Jul 16 08:17:00 2012
Log: Add histogram for total heap fragmentation, don't report
fragmentation for new space, and report fragmentation, not usage
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10778009
Patch from Jochen Eisinger <[email protected]>.
http://code.google.com/p/v8/source/detail?r=12099
Modified:
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/v8-counters.h
=======================================
--- /branches/bleeding_edge/src/heap.cc Mon Jul 16 07:02:50 2012
+++ /branches/bleeding_edge/src/heap.cc Mon Jul 16 08:17:00 2012
@@ -447,26 +447,38 @@
isolate_->counters()->number_of_symbols()->Set(
symbol_table()->NumberOfElements());
-#define
UPDATE_COUNTERS_FOR_SPACE(space) \
-
isolate_->counters()->space##_bytes_available()->Set( \
-
static_cast<int>(space()->Available())); \
-
isolate_->counters()->space##_bytes_committed()->Set( \
-
static_cast<int>(space()->CommittedMemory())); \
-
isolate_->counters()->space##_bytes_used()->Set( \
-
static_cast<int>(space()->SizeOfObjects())); \
- if (space()->CommittedMemory() > 0)
{ \
-
isolate_->counters()->external_fragmentation_##space()->AddSample( \
-
static_cast<int>( \
- (space()->SizeOfObjects() * 100) /
space()->CommittedMemory())); \
- }
+ if (CommittedMemory() > 0) {
+ isolate_->counters()->external_fragmentation_total()->AddSample(
+ static_cast<int>(100 - (SizeOfObjects() * 100.0) /
CommittedMemory()));
+ }
+
+#define
UPDATE_COUNTERS_FOR_SPACE(space) \
+
isolate_->counters()->space##_bytes_available()->Set(
\
+
static_cast<int>(space()->Available())); \
+
isolate_->counters()->space##_bytes_committed()->Set(
\
+
static_cast<int>(space()->CommittedMemory())); \
+
isolate_->counters()->space##_bytes_used()->Set(
\
+ static_cast<int>(space()->SizeOfObjects()));
+#define
UPDATE_FRAGMENTATION_FOR_SPACE(space) \
+ if (space()->CommittedMemory() > 0)
{ \
+
isolate_->counters()->external_fragmentation_##space()->AddSample( \
+ static_cast<int>(100
- \
+ (space()->SizeOfObjects() * 100.0) /
space()->CommittedMemory())); \
+ }
+#define
UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(space) \
+
UPDATE_COUNTERS_FOR_SPACE(space)
\
+ UPDATE_FRAGMENTATION_FOR_SPACE(space)
+
UPDATE_COUNTERS_FOR_SPACE(new_space)
- UPDATE_COUNTERS_FOR_SPACE(old_pointer_space)
- UPDATE_COUNTERS_FOR_SPACE(old_data_space)
- UPDATE_COUNTERS_FOR_SPACE(code_space)
- UPDATE_COUNTERS_FOR_SPACE(map_space)
- UPDATE_COUNTERS_FOR_SPACE(cell_space)
- UPDATE_COUNTERS_FOR_SPACE(lo_space)
+ UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(old_pointer_space)
+ UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(old_data_space)
+ UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(code_space)
+ UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(map_space)
+ UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(cell_space)
+ UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE(lo_space)
#undef UPDATE_COUNTERS_FOR_SPACE
+#undef UPDATE_FRAGMENTATION_FOR_SPACE
+#undef UPDATE_COUNTERS_AND_FRAGMENTATION_FOR_SPACE
#if defined(DEBUG)
ReportStatisticsAfterGC();
=======================================
--- /branches/bleeding_edge/src/v8-counters.h Fri Jul 13 05:22:09 2012
+++ /branches/bleeding_edge/src/v8-counters.h Mon Jul 16 08:17:00 2012
@@ -52,8 +52,8 @@
#define HISTOGRAM_PERCENTAGE_LIST(HP) \
- HP(external_fragmentation_new_space, \
- V8.MemoryExternalFragmentationNewSpace) \
+ HP(external_fragmentation_total, \
+ V8.MemoryExternalFragmentationTotal) \
HP(external_fragmentation_old_pointer_space, \
V8.MemoryExternalFragmentationOldPointerSpace) \
HP(external_fragmentation_old_data_space, \
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
