http://codereview.chromium.org/10778011/diff/2001/src/objects.cc File src/objects.cc (right):
http://codereview.chromium.org/10778011/diff/2001/src/objects.cc#newcode12533 src/objects.cc:12533: MaybeObject* maybe_fields = Even if it is too late, I'd like to comment on this kind of change: I strongly dislike removing these scopes, because this actively destroys very useful information. Using a tiny scope makes it crystal-clear what is going on (namely a bind operation in the Maybe monad) and that the MaybeObject* is only used locally. I wouldn't argue much if all our functions were in the 10-lines range, but given our usual monstrous code chunks, the scope really has a value when trying to understand/refactor things. We should make reading our code *easier*, not harder... http://codereview.chromium.org/10778011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
