LGTM with nits. Also, can I suggest adding FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST to statistics-extension.cc to expose it using getV8Statistics()?
https://chromiumcodereview.appspot.com/10797008/diff/3001/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10797008/diff/3001/src/mark-compact.cc#newcode947 src/mark-compact.cc:947: static void ObjectStatsVisitCore(StaticVisitorBase::VisitorId id, We sometimes call this sort of stuff *Base. Maybe better than *Core? https://chromiumcodereview.appspot.com/10797008/diff/3001/src/mark-compact.cc#newcode1552 src/mark-compact.cc:1552: FAST_PROPERTIES_SUB_TYPE); This looks exactly the same as the case above. Since JSArray is a subclass of JSObject, why the specialization? The accessors to elements and properties are the same ones anyways. https://chromiumcodereview.appspot.com/10797008/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
