Reviewers: Jakob, ulan,
Message:
Rename "Error" to "ANDROID"
There is a case mjsunit/compiler/regress-stacktrace.js which print "Error
urg"
and android test runner thinks it is a failed case as the return value is 1.
Feel free to change ANDROID to other value if you want.
BTW, the upstream tools/android-build.sh has no exec permission, please
help to
add the permission.
Description:
Android test runner: Rename "Error" to "ANDROID"
Please review this at https://chromiumcodereview.appspot.com/10809010/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/message/testcfg.py
M tools/android-run.py
Index: test/message/testcfg.py
===================================================================
--- test/message/testcfg.py (revision 12136)
+++ test/message/testcfg.py (working copy)
@@ -44,7 +44,7 @@
"""Ignore empty lines, valgrind output and Android output."""
if not str: return True
return (str.startswith('==') or str.startswith('**') or
- str.startswith('Error'))
+ str.startswith('ANDROID'))
def IsFailureOutput(self, output):
f = file(self.expected)
Index: tools/android-run.py
===================================================================
--- tools/android-run.py (revision 12136)
+++ tools/android-run.py (working copy)
@@ -42,7 +42,7 @@
import tempfile
def Check(output, errors):
- failed = any([s.startswith('/system/bin/sh:') or s.startswith('Error')
+ failed = any([s.startswith('/system/bin/sh:') or s.startswith('ANDROID')
for s in output.split('\n')])
return 1 if failed else 0
@@ -93,7 +93,7 @@
script = (" ".join(args) + "\n"
"case $? in\n"
" 0) break;;\n"
- " *) echo \"Error returned by test\";;\n"
+ " *) echo \"ANDROID: Error returned by test\";;\n"
"esac\n")
script = script.replace(workspace, android_workspace)
script_file = WriteToTemporaryFile(script)
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
