LGTM with a nit.

https://chromiumcodereview.appspot.com/10803032/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10803032/diff/1/src/objects.h#newcode4905
src/objects.h:4905: DescriptorArray* descs, String* name, int last_add,
TransitionFlag flag);
nit: for method declarations, one line per argument please. Also, please
keep the arguments' names in the declaration the same as in the
implementation.

https://chromiumcodereview.appspot.com/10803032/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to