A few nits, and a question in objects.cc.
https://chromiumcodereview.appspot.com/10802034/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10802034/diff/1/src/heap.cc#newcode2056 src/heap.cc:2056: Object* result; You can make this a Map* while you are at it. https://chromiumcodereview.appspot.com/10802034/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10802034/diff/1/src/objects.cc#newcode4945 src/objects.cc:4945: new_descriptors, key, LastAdded(), flag); nit: fits on one line. https://chromiumcodereview.appspot.com/10802034/diff/1/src/objects.cc#newcode7228 src/objects.cc:7228: IsShared::update(other->bit_field3(), true), Using 'true' for IsShared inverts the previous logic, is that on purpose? https://chromiumcodereview.appspot.com/10802034/diff/1/test/cctest/test-alloc.cc File test/cctest/test-alloc.cc (right): https://chromiumcodereview.appspot.com/10802034/diff/1/test/cctest/test-alloc.cc#newcode1 test/cctest/test-alloc.cc:1: // Copyright 2011 the V8 project authors. All rights reserved. nit: 2012 https://chromiumcodereview.appspot.com/10802034/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
