LGTM (with nits).
https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc#newcode2786 src/arm/lithium-codegen-arm.cc:2786: __ add(scratch, elements, Operand(key, LSL, kPointerSizeLog2 - 1)); Can we use kSmiTagSize here? https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc#newcode2818 src/arm/lithium-codegen-arm.cc:2818: ? (element_size_shift - 1) : element_size_shift; Likewise. https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc#newcode2874 src/arm/lithium-codegen-arm.cc:2874: return MemOperand(base, key, LSR, 1); Likewise. https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc#newcode2882 src/arm/lithium-codegen-arm.cc:2882: return MemOperand(base, scratch0(), LSR, 1); Likewise. https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc#newcode2904 src/arm/lithium-codegen-arm.cc:2904: ? (element_size_shift - 1) : element_size_shift; Likewise. https://chromiumcodereview.appspot.com/10735020/diff/21001/src/arm/lithium-codegen-arm.cc#newcode3844 src/arm/lithium-codegen-arm.cc:3844: __ add(scratch, elements, Operand(key, LSL, kPointerSizeLog2 - 1)); Likewise. https://chromiumcodereview.appspot.com/10735020/diff/21001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://chromiumcodereview.appspot.com/10735020/diff/21001/src/ia32/lithium-codegen-ia32.cc#newcode2706 src/ia32/lithium-codegen-ia32.cc:2706: if (key_representation.IsTagged() && shift_size >= 1) { Can we also make this condition use !ExternalArrayOpRequiresTemp(...) and instead ASSERT(shift_size >= kSmiTagSize)? https://chromiumcodereview.appspot.com/10735020/diff/21001/src/ia32/lithium-codegen-ia32.cc#newcode2707 src/ia32/lithium-codegen-ia32.cc:2707: shift_size -= 1; Can we use kSmiTagSize here? https://chromiumcodereview.appspot.com/10735020/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
