https://chromiumcodereview.appspot.com/10735020/diff/21001/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/10735020/diff/21001/src/ia32/lithium-codegen-ia32.cc#newcode2706 src/ia32/lithium-codegen-ia32.cc:2706: if (key_representation.IsTagged() && shift_size >= 1) { On 2012/07/20 10:40:27, danno wrote:
On 2012/07/19 21:02:23, Michael Starzinger wrote: > Can we also make this condition use
!ExternalArrayOpRequiresTemp(...) and
> instead ASSERT(shift_size >= kSmiTagSize)?
Actually, it turns out that ExternalArrayOpRequiresTemp test something difference, and one is not replaceable by the other, so I'm leaving
the code
as-is.
I see, OK. Just use the kSmiTagSize constant. https://chromiumcodereview.appspot.com/10735020/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
