On 2012/07/20 13:47:48, Toon Verwaest wrote:
LGTM with nits.
http://codereview.chromium.org/10802051/diff/2001/src/objects.cc File src/objects.cc (right):
http://codereview.chromium.org/10802051/diff/2001/src/objects.cc#newcode12463 src/objects.cc:12463: } What about moving all of this code (starting from // Calculate fields ...)
below
the == 0?
http://codereview.chromium.org/10802051/diff/2001/src/objects.cc#newcode12466 src/objects.cc:12466: ASSERT_EQ(0, number_of_allocated_fields); Here we can just use number_of_fields.
PTAL. http://codereview.chromium.org/10802051/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
