As discussed offline, I've addressed 2 review comments and experiment with a
simple case of inlining for the rest to see if we're heading into the
direction
with this refactoring.
No need to review things right now, I'll ping again when something is
actually
working.
http://codereview.chromium.org/10801013/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
http://codereview.chromium.org/10801013/diff/1/src/hydrogen.cc#newcode4778
src/hydrogen.cc:4778: CHECK_ALIVE(store = BuildCallSetter(literal,
On 2012/07/19 13:28:13, Michael Starzinger wrote:
For object literals we should never get an accessor because we always
use the
internal Object() constructor and duplicate identifiers are not
allowed in
literals. So better turn this into an assertion here.
Done.
http://codereview.chromium.org/10801013/diff/1/src/hydrogen.cc#newcode5688
src/hydrogen.cc:5688: bool HGraphBuilder::IsAccessorCall(Handle<Map>
map,
On 2012/07/19 13:28:13, Michael Starzinger wrote:
The name of this method is misleading, because it actually performs a
lookup.
Can we call it "LookupAccessorCall" or "LookupAccessorPair" instead?
Done.
http://codereview.chromium.org/10801013/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
