lgtm with nits.
https://chromiumcodereview.appspot.com/10810056/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/10810056/diff/1/test/cctest/test-api.cc#newcode5786 test/cctest/test-api.cc:5786: utf8buf[5] = 'X'; // Test that the sixth character is left untouched. This comment probably belongs on line 5790. https://chromiumcodereview.appspot.com/10810056/diff/1/test/cctest/test-api.cc#newcode5794 test/cctest/test-api.cc:5794: CHECK_EQ(0, strcmp(utf8buf, "abcde")); Testing with strcmp and strncmp seems superfluous. https://chromiumcodereview.appspot.com/10810056/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
