LGTM with nits.

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode6
ChangeLog:6: Added dependency to HLoadKeyed* instructions to prevent
invalid hoisting.
nit: long line

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode9
ChangeLog:9: Enabled building V8 for Android on Mac
nit: missing full stop. Also, let's make this s/V8/d8/

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode17
ChangeLog:17: Fixed Windows build spam.
I don't think this is relevant.

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode20
ChangeLog:20: Preserve rsi when probing for CPU features.
Is this visible to embedders/users?

https://chromiumcodereview.appspot.com/10790138/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to