http://codereview.chromium.org/10818026/diff/3002/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/10818026/diff/3002/src/arm/assembler-arm.cc#newcode132 src/arm/assembler-arm.cc:132: ASSERT(!IsSupported(VFP3) || (IsSupported(VFP2) && IsSupported(ARMv7))); It is possible to have an ARMv7 core without VFP and in this case the assert would fail. It is an uncommon configuration though. http://codereview.chromium.org/10818026/diff/3002/src/arm/assembler-arm.cc#newcode1924 src/arm/assembler-arm.cc:1924: ASSERT(CpuFeatures::IsEnabled(VFP2)); I would leave VFP3 as a requirement as this function only makes sense for VFPv3. http://codereview.chromium.org/10818026/diff/3002/src/arm/assembler-arm.cc#newcode1981 src/arm/assembler-arm.cc:1981: CpuFeatures::IsSupported(VFP3)) { Reverse the order of the test, then FitsVMOVDoubleImmediate can assert VFP3 support. http://codereview.chromium.org/10818026/diff/3002/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/10818026/diff/3002/src/arm/code-stubs-arm.cc#newcode3990 src/arm/code-stubs-arm.cc:3990: __ Vmov(kDoubleRegZero, 0.0); The Vmov macro will use kDoubleRegZero if one wont to move 0.0 into a VFP reg. The kdoubleRegZero is initialised with the value 0.0 here so you need to use the instruction vmov not the marcro instruction. http://codereview.chromium.org/10818026/diff/3002/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/10818026/diff/3002/src/arm/stub-cache-arm.cc#newcode2096 src/arm/stub-cache-arm.cc:2096: CpuFeatures::Scope scope_vfp3(VFP2); scope_vfp2 http://codereview.chromium.org/10818026/diff/3002/src/platform-linux.cc File src/platform-linux.cc (right): http://codereview.chromium.org/10818026/diff/3002/src/platform-linux.cc#newcode136 src/platform-linux.cc:136: search_string = "vfp"; this will match the vfpv3 string since when they differ the search_string will have reach '\0'. Maybe put "vfp " http://codereview.chromium.org/10818026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
