LGTM (with a few nits).
https://chromiumcodereview.appspot.com/10830005/diff/1/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10830005/diff/1/src/objects.cc#newcode2109 src/objects.cc:2109: enum RightTrimPhase { FROM_GC, FROM_MUTATOR }; Let's call that RightTrimMode or something like that. https://chromiumcodereview.appspot.com/10830005/diff/1/src/objects.cc#newcode2120 src/objects.cc:2120: template<RightTrimPhase trim_phase> Let's call that trim_mode. https://chromiumcodereview.appspot.com/10830005/diff/1/src/objects.cc#newcode2221 src/objects.cc:2221: int new_array_size = DescriptorArray::SizeFor(new_number_of_descriptors); Nice catch. https://chromiumcodereview.appspot.com/10830005/diff/1/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/10830005/diff/1/src/objects.h#newcode4971 src/objects.h:4971: Handle<Object> descriptors); Empty new-line after the declaration. https://chromiumcodereview.appspot.com/10830005/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
