LGTM (with one nit).
http://codereview.chromium.org/10826028/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/10826028/diff/1/src/hydrogen.cc#newcode4768 src/hydrogen.cc:4768: Handle<String>::cast(property->key()->handle()); Consider using property->key()->AsPropertyName() here. http://codereview.chromium.org/10826028/diff/1/src/hydrogen.h File src/hydrogen.h (right): http://codereview.chromium.org/10826028/diff/1/src/hydrogen.h#newcode1152 src/hydrogen.h:1152: Handle<AccessorPair> accessors, I like that, much cleaner! http://codereview.chromium.org/10826028/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
