LGTM (with a suggestion).
https://chromiumcodereview.appspot.com/10828048/diff/1/test/cctest/test-heap.cc File test/cctest/test-heap.cc (right): https://chromiumcodereview.appspot.com/10828048/diff/1/test/cctest/test-heap.cc#newcode1983 test/cctest/test-heap.cc:1983: CHECK(maybe_obj->To<JSFunction>(&g_func)); Consider using the following to get to the "g" function ... Handle<JSFunction> g = v8::Utils::OpenHandle( *v8::Handle<v8::Function>::Cast( v8::Context::GetCurrent()->Global()->Get(v8_str("g")))); https://chromiumcodereview.appspot.com/10828048/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
