On 2012/07/26 07:25:34, haitao.feng wrote:
Rewrite Makefile rules for Android to allow parallel execution.

Basically we want to invoke make by the following interface:
   make $arch.$mode.check -jN

The problem is that for Android, the arch might be android_ia32 or android_arm
and they have different configurations of toolchains and gyp_defines. The
solution is adding an indirection. Previously this is done by
tools/android-build.sh while it disabled parallel building.

Now I rewrite all the android-build.sh logic by using a new Makefile.android:
   1) There is no "case" statement in Make. Replaced with ifeq/else
ifeq/else/endif
2) It turns out MAKEFILES is a reserved word in Make. If we do not change
the
name, the "@$(MAKE) -f Makefile.android $@" will search
out/Makefile.[arm|ia32|x64|mipsel] and things are totally messed.

Please let me know any issue in the future and I am willing to help :)

LGTM. Landing.

http://codereview.chromium.org/10824039/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to