Landing...
http://codereview.chromium.org/10828066/diff/2001/src/ast.h File src/ast.h (right): http://codereview.chromium.org/10828066/diff/2001/src/ast.h#newcode1515 src/ast.h:1515: int ReturnId() const { return return_id_; } On 2012/07/30 09:38:43, Michael Starzinger wrote:
Can we put the usual "// Bailout support." comment in from of the ID
getter,
that helps us grep for all occurences where IDs are used for bailout
points. Done. http://codereview.chromium.org/10828066/diff/2001/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/10828066/diff/2001/src/flag-definitions.h#newcode174 src/flag-definitions.h:174: "inline JavaScript accessors (not fully functional yet)") On 2012/07/30 09:38:43, Michael Starzinger wrote:
Can we move that down to the other inline flags like inline_construct?
Also drop
the "not fully functional yet" comment.
Done. http://codereview.chromium.org/10828066/diff/2001/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/10828066/diff/2001/src/hydrogen.cc#newcode6928 src/hydrogen.cc:6928: bool HGraphBuilder::TryInlineGetter(Handle<JSFunction> getter, On 2012/07/30 09:38:43, Michael Starzinger wrote:
It might be better to pass the "Property* expr" as first parameter
instead of
the two IDs and let this helper method load get the appropriate IDs.
Because a
getter can only be called if you have the appropriate "Property" AST
node
available.
Done. http://codereview.chromium.org/10828066/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
