Addressed comments. Landing.
https://chromiumcodereview.appspot.com/10830049/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://chromiumcodereview.appspot.com/10830049/diff/1/src/flag-definitions.h#newcode556 src/flag-definitions.h:556: "verify that code embeds at most one global context after GC") On 2012/07/30 10:09:38, Toon Verwaest wrote:
embeds -> holds on to?
Done. https://chromiumcodereview.appspot.com/10830049/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://chromiumcodereview.appspot.com/10830049/diff/1/src/mark-compact.cc#newcode264 src/mark-compact.cc:264: array->set_length(0); On 2012/07/30 10:09:38, Toon Verwaest wrote:
Adding a comment here is probably useful. Why do we need this trick
here but
don't we handle objects specially? Can't we use the same mechanism for
arrays as
we do for objects somehow?
Done. For JSObjects we don't have the problem, because we don't iterate over their bodies. The external mark bits cannot be used because of lazy sweeping. We could use intrusive marking, but that would make this visitor much more complicated. https://chromiumcodereview.appspot.com/10830049/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
