Hi Alan, both Jakob and I are convinced that the current state of the GYP file offers a better readability and less redundancy. We would very much like to keep it the way it is.
Regards, Yang On Mon, Jul 30, 2012 at 7:46 PM, Alan Leung <[email protected]> wrote: > Hi. > > Thanks for taking a look. > > To be honest, I didn't make that change so I don't prefer it one way or > another. My goal at the moment is just trying to sync up the two branches. > > If most people on v8-dev agrees this is less readable, I will try to > convince the chrome for android team intead. > > -Alan > > On Mon, Jul 30, 2012 at 4:40 AM, <[email protected]> wrote: > >> On 2012/07/28 15:23:24, Jakob wrote: >> >>> Drive-by comment: >>> >> >> Can you please elaborate why this change is necessary? AFAIK the required >>> >> files >> >>> are: >>> - Mac host, host toolset: platform-macos.cc >>> - Mac host, target toolset: platform-linux.cc >>> - Linux host, both host and target toolset: platform-linux.cc >>> It looks to me like both the old and the new code accomplish this, and >>> I'm >>> finding the old version slightly easier to understand. >>> >> >> I also don't see why this change is necessary. Please elaborate. >> >> https://chromiumcodereview.**appspot.com/10823064/<https://chromiumcodereview.appspot.com/10823064/> >> > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
