LGTM (with one comment).
https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc File src/heap.cc (left): https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc#oldcode6879 src/heap.cc:6879: Can we have that empty newline back? https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10536147/diff/4002/src/heap.cc#newcode551 src/heap.cc:551: if (FLAG_trace_incremental_marking && !FLAG_trace_gc_ignore_scavenger) { Actually, I would like to see that with --trace-incremental-marking, it is independent from --trace-gc. https://chromiumcodereview.appspot.com/10536147/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
