Addressed comments, PTAL.
http://codereview.chromium.org/10824079/diff/21/src/handles.cc File src/handles.cc (right): http://codereview.chromium.org/10824079/diff/21/src/handles.cc#newcode726 src/handles.cc:726: // Count encountering the empty descriptor array as a cache hit. On 2012/08/06 15:06:22, Michael Starzinger wrote:
Hmm, "encountering" is an adjective, I would just drop the comment
completely. Done. http://codereview.chromium.org/10824079/diff/21/src/handles.cc#newcode729 src/handles.cc:729: return Handle<FixedArray>(isolate->factory()->empty_fixed_array()); On 2012/08/06 15:06:22, Michael Starzinger wrote:
No need for a copy constructor of the handle here!
Done. http://codereview.chromium.org/10824079/diff/21/src/handles.cc#newcode742 src/handles.cc:742: storage = isolate->factory()->NewFixedArray(num_enum); On 2012/08/06 15:06:22, Michael Starzinger wrote:
Can we just merge the handle declarations and the allocations into one
line? Done. http://codereview.chromium.org/10824079/diff/21/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/10824079/diff/21/src/heap.cc#newcode2078 src/heap.cc:2078: Map::EnumLengthBits::update( On 2012/08/06 15:06:22, Michael Starzinger wrote:
This is a little convoluted. Better use ...
map->set_bit_field3(Map::LastAddedBits::encode(Map::kNoneAdded) |
Map::EnumLengthBits::encode(Map::kInvalidEnumCache)); Done. http://codereview.chromium.org/10824079/diff/21/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/10824079/diff/21/src/hydrogen-instructions.h#newcode109 src/hydrogen-instructions.h:109: V(MapEnumLength) \ On 2012/08/06 15:06:22, Michael Starzinger wrote:
Alpha-sort!
Done. http://codereview.chromium.org/10824079/diff/21/src/ia32/full-codegen-ia32.cc File src/ia32/full-codegen-ia32.cc (right): http://codereview.chromium.org/10824079/diff/21/src/ia32/full-codegen-ia32.cc#newcode1093 src/ia32/full-codegen-ia32.cc:1093: Label no_descriptors; On 2012/08/06 15:06:22, Michael Starzinger wrote:
Move this up above the __ bind() but below the comment. Also drop all
the empty
newlines around the label. The label isn't the central thing here, the
assembler
instructions are.
Done. http://codereview.chromium.org/10824079/diff/21/src/ia32/lithium-ia32.h File src/ia32/lithium-ia32.h (right): http://codereview.chromium.org/10824079/diff/21/src/ia32/lithium-ia32.h#newcode93 src/ia32/lithium-ia32.h:93: V(MapEnumLength) \ On 2012/08/06 15:06:22, Michael Starzinger wrote:
Alpha-sort!
Done. http://codereview.chromium.org/10824079/diff/21/src/objects.h File src/objects.h (right): http://codereview.chromium.org/10824079/diff/21/src/objects.h#newcode4888 src/objects.h:4888: int LastAdded() { On 2012/08/06 15:06:22, Michael Starzinger wrote:
Can we move LastAdded() up just above SetLastAdded()?
Done. http://codereview.chromium.org/10824079/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
