LGTM except for two ARM-specific comments. I removed those comments and am landing this patch.
https://chromiumcodereview.appspot.com/10854053/diff/1/src/mips/lithium-codegen-mips.cc File src/mips/lithium-codegen-mips.cc (right): https://chromiumcodereview.appspot.com/10854053/diff/1/src/mips/lithium-codegen-mips.cc#newcode1399 src/mips/lithium-codegen-mips.cc:1399: // We could use a single 'vorr' instruction here if we had NEON support. Comment only applies to ARM. https://chromiumcodereview.appspot.com/10854053/diff/1/src/mips/lithium-codegen-mips.cc#newcode1404 src/mips/lithium-codegen-mips.cc:1404: // Since we operate on +0 and/or -0, vadd and vand have the same effect; Comment only applies to ARM. https://chromiumcodereview.appspot.com/10854053/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
