Reviewers: Erik Corry,
https://chromiumcodereview.appspot.com/10828303/diff/2001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/10828303/diff/2001/src/arm/stub-cache-arm.cc#newcode1248 src/arm/stub-cache-arm.cc:1248: __ push(dictionary); On 2012/08/14 11:03:33, Erik Corry wrote:
This is slow on ARM and unnecessary when there are 16 registers.
Done. Description: Fix improved LoadICs for dictionaries with callbacks. This fixes the positive lookup performed by these LoadICs, to use the holder instead of the receiver to perfrom the lookup on. It also extends this improvement to KeyedLoadICs. And it fixes a bug introduced for the JavaScript getter case of a LoadIC. [email protected] BUG=chromium:142088 TEST=cctest/test-api/Regress142088,cctest/test-api/Regress137002b Please review this at https://chromiumcodereview.appspot.com/10828303/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/arm/stub-cache-arm.cc M src/ia32/stub-cache-ia32.cc M src/ic.cc M src/stub-cache.h M src/x64/ic-x64.cc M src/x64/stub-cache-x64.cc M test/cctest/test-api.cc -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
