lgtm with comments
https://chromiumcodereview.appspot.com/10830334/diff/1/src/code-stubs.cc File src/code-stubs.cc (right): https://chromiumcodereview.appspot.com/10830334/diff/1/src/code-stubs.cc#newcode183 src/code-stubs.cc:183: Isolate* isolate = known_map_->GetIsolate(); I would add an assertion here and in AddToSpecialCache that verifies that operator is either === or == https://chromiumcodereview.appspot.com/10830334/diff/1/src/code-stubs.cc#newcode195 src/code-stubs.cc:195: *code_out = Code::cast(*probe); I wonder if we can fetch some information from the code object here and assert that they match expected values? (e.g. operator, map?) https://chromiumcodereview.appspot.com/10830334/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
