LGTM (with comments on the changelog).

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog#newcode4
ChangeLog:4: (Chromium issue 142088)
We didn't even mention the improvement itself in the last changelog ...
let's just drop it.

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog#newcode7
ChangeLog:7: (Chromium issue 140050)
That's only a check, not a fix for that issue. Let's also drop it.

https://chromiumcodereview.appspot.com/10836290/diff/1/ChangeLog#newcode9
ChangeLog:9: Fixed wrong indexing in global regexp.
I think we can also drop this one.

https://chromiumcodereview.appspot.com/10836290/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to