Thanks, comments are addressed, landing.
https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.cc#newcode1 test/cctest/test-api.cc:1: On 2012/08/10 15:49:10, Michael Starzinger wrote:
Don't remove the copyright line, looks like a typo.
Done. https://chromiumcodereview.appspot.com/10836189/diff/1/test/cctest/test-api.cc#newcode14642 test/cctest/test-api.cc:14642: v8::V8::ContextDisposedNotification(); On 2012/08/10 15:49:10, Michael Starzinger wrote:
Can we move that out of the loop to where the context is actually
disposed? Also
if the line is right after the disposal, the comment is no longer
needed I
think.
Done. https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-script.js File test/mjsunit/debug-script.js (right): https://chromiumcodereview.appspot.com/10836189/diff/1/test/mjsunit/debug-script.js#newcode31 test/mjsunit/debug-script.js:31: On 2012/08/10 15:49:10, Michael Starzinger wrote:
Drop this empty newline.
Done. https://chromiumcodereview.appspot.com/10836189/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
