Reviewers: danno,

Description:
Fix order of conversions in ObjectToInt32 and ObjectToUint32 helpers.

[email protected]
BUG=


Please review this at https://chromiumcodereview.appspot.com/10878012/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/deoptimizer.cc


Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index b0a19845974eda7224371396d47413230e99d87c..8cab88f0f6594278445fd25f1ce857e6977c3d81 100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -954,7 +954,7 @@ static bool ObjectToInt32(Object* obj, int32_t* value) {

   if (obj->IsHeapNumber()) {
     double num = HeapNumber::cast(obj)->value();
-    if (FastD2I(FastI2D(num)) != num) {
+    if (FastI2D(FastD2I(num)) != num) {
       if (FLAG_trace_osr) {
         PrintF("**** %g could not be converted to int32 ****\n",
                HeapNumber::cast(obj)->value());
@@ -980,7 +980,7 @@ static bool ObjectToUint32(Object* obj, uint32_t* value) {

   if (obj->IsHeapNumber()) {
     double num = HeapNumber::cast(obj)->value();
-    if ((num < 0) || (FastD2UI(FastUI2D(num)) != num)) {
+    if ((num < 0) || (FastUI2D(FastD2UI(num)) != num)) {
       if (FLAG_trace_osr) {
         PrintF("**** %g could not be converted to uint32 ****\n",
                HeapNumber::cast(obj)->value());


--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to