https://chromiumcodereview.appspot.com/10870049/diff/1/src/mips/simulator-mips.cc File src/mips/simulator-mips.cc (right):
https://chromiumcodereview.appspot.com/10870049/diff/1/src/mips/simulator-mips.cc#newcode2073 src/mips/simulator-mips.cc:2073: double rounded = fs > 0 ? floor(fs + 0.5) : ceil(fs - 0.5); Why not just do floor(fs + 0.5) for both positive and negative values? https://chromiumcodereview.appspot.com/10870049/diff/1/src/mips/simulator-mips.cc#newcode2075 src/mips/simulator-mips.cc:2075: if ((result & 1) != 0 && result - fs == 0.5) { This doesn't handle the case when fs is negative, e.g. fs == -4.5, result == -5, result-fs == -0.5. https://chromiumcodereview.appspot.com/10870049/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
