LGTM with comments. I like this. Just the naming issue that I found a bit misleading.
http://codereview.chromium.org/10795074/diff/30005/src/log.h File src/log.h (right): http://codereview.chromium.org/10795074/diff/30005/src/log.h#newcode333 src/log.h:333: void IssueCodeAddedNotification(Code* code, How about IssueCodeAddedEvent? Here and below, when you say Notification I think you mean Event. So maybe PostCodeAddedEvent or SendCodeAddedEvent(). Otherwise it's unclear that this routine doesn't actually do more. http://codereview.chromium.org/10795074/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
