LGTM with nits.

https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc#newcode6191
src/hydrogen.cc:6191: HInstruction* elements =
AddInstruction(new(zone()) HLoadElements(object,
nit: let's be consistent and break the line after '='.

https://chromiumcodereview.appspot.com/10918005/diff/1/src/hydrogen.cc#newcode6379
src/hydrogen.cc:6379: HInstruction* elements =
AddInstruction(new(zone()) HLoadElements(object,
nit: let's be consistent and break the line after '='.

https://chromiumcodereview.appspot.com/10918005/diff/1/test/mjsunit/regress/regress-load-elements.js
File test/mjsunit/regress/regress-load-elements.js (right):

https://chromiumcodereview.appspot.com/10918005/diff/1/test/mjsunit/regress/regress-load-elements.js#newcode45
test/mjsunit/regress/regress-load-elements.js:45: // Optimize, before
the fix, the element load and subsequent tagged-to-i were
Outdated comment. At least, s/tagged-to-i/fixed-array-length/

https://chromiumcodereview.appspot.com/10918005/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to