LGTM with comments addressed.
https://chromiumcodereview.appspot.com/10911063/diff/1/src/accessors.cc File src/accessors.cc (right): https://chromiumcodereview.appspot.com/10911063/diff/1/src/accessors.cc#newcode754 src/accessors.cc:754: while (potential_caller != NULL && potential_caller->IsBuiltin()) { This suggest that potential_caller can become NULL, in which case setting caller to potential_caller would cause NULL dereference later. https://chromiumcodereview.appspot.com/10911063/diff/1/test/mjsunit/regress/regress-145201.js File test/mjsunit/regress/regress-145201.js (right): https://chromiumcodereview.appspot.com/10911063/diff/1/test/mjsunit/regress/regress-145201.js#newcode67 test/mjsunit/regress/regress-145201.js:67: if (/native/i.test(caller) || /ADD/.test(caller)) { Why do we only test for /ADD/, not for e.g. /MUL/? https://chromiumcodereview.appspot.com/10911063/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
