LGTM if confirmed to push usable content onto the stack. And comments.
https://chromiumcodereview.appspot.com/10917086/diff/5/src/isolate.cc File src/isolate.cc (right): https://chromiumcodereview.appspot.com/10917086/diff/5/src/isolate.cc#newcode546 src/isolate.cc:546: String::WriteToFlat(*trace, buffer, 0, length - 1); Not sure if we need to null-terminate the string. Probably should. https://chromiumcodereview.appspot.com/10917086/diff/5/src/isolate.h File src/isolate.h (right): https://chromiumcodereview.appspot.com/10917086/diff/5/src/isolate.h#newcode713 src/isolate.h:713: unsigned int magic2); Maybe even add the NO_INLINE macro here. Though probably not necessary. https://chromiumcodereview.appspot.com/10917086/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
