Looks good so far, but please add disassembler support for the newly added instruction.
https://chromiumcodereview.appspot.com/10937013/diff/1/test/mjsunit/deopt-minus-zero.js File test/mjsunit/deopt-minus-zero.js (right): https://chromiumcodereview.appspot.com/10937013/diff/1/test/mjsunit/deopt-minus-zero.js#newcode42 test/mjsunit/deopt-minus-zero.js:42: return a * b; spaces instead of the tab, please. https://chromiumcodereview.appspot.com/10937013/diff/1/test/mjsunit/deopt-minus-zero.js#newcode56 test/mjsunit/deopt-minus-zero.js:56: assertFalse(raw_optimized == OptimizationState.NO); This is the clean way to do it; in many other test cases we just assertTrue(%GetOptimizationStatus(mul) != 2). It's up to you whether you leave it as it is, or simplify it. https://chromiumcodereview.appspot.com/10937013/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
