Addressed comments.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.cc
File src/objects.cc (right):
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.cc#newcode7563
src/objects.cc:7563: RightTrimFixedArray<FROM_GC>(heap, t, trim);
On 2012/09/19 09:34:55, Michael Starzinger wrote:
Can we use "t->IsSimpleTransition() ? trim : trim *
TransitionArray::kTransitionSize" here?
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.h
File src/objects.h (right):
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.h#newcode179
src/objects.h:179:
On 2012/09/19 09:34:55, Michael Starzinger wrote:
Insert second empty newline here.
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.h#newcode180
src/objects.h:180: // Indicates whether the transition is simple: it
either adds a property to a
On 2012/09/19 09:34:55, Michael Starzinger wrote:
The comment is slightly confusing to me. Can we rephrase the second
part? What
is "it" in this sentence?
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.h#newcode186
src/objects.h:186:
On 2012/09/19 09:34:55, Michael Starzinger wrote:
Insert second empty newline here.
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.h#newcode4849
src/objects.h:4849: SimpleTransitionFlag flag = SIMPLE_TRANSITION);
On 2012/09/19 09:34:55, Michael Starzinger wrote:
The Google C++ Style Guide doesn't like default arguments. We
sometimes break
that rule. But since this method only has two call-sites, I think it's
not worth
here.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Default_Arguments
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/objects.h#newcode5001
src/objects.h:5001: int descriptor_index = 0);
On 2012/09/19 09:34:55, Michael Starzinger wrote:
Likewise. Although there are more call-sites here. But they are all in
objects.cc, so I also think it's not worth here.
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/transitions-inl.h
File src/transitions-inl.h (right):
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/transitions-inl.h#newcode73
src/transitions-inl.h:73: return get(kElementsTransitionIndex) !=
Smi::FromInt(0);
On 2012/09/19 09:34:55, Michael Starzinger wrote:
Can we turn that into ...
return IsFullTransitionArray() &&
get(kElementsTransitionIndex) != Smi::FromInt(0);
Done.
https://chromiumcodereview.appspot.com/10915260/diff/16001/src/transitions-inl.h#newcode128
src/transitions-inl.h:128: return prototype_transitions !=
Smi::FromInt(0);
On 2012/09/19 09:34:55, Michael Starzinger wrote:
Can we turn that into ...
return IsFullTransitionArray() &&
get(kPrototypeTransitionsIndex) != Smi::FromInt(0);
Done.
https://chromiumcodereview.appspot.com/10915260/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
