[v8-dev] [v8] r12548 committed - Fixed minus zero test (fixes v8:2133)....

Wed, 19 Sep 2012 05:49:14 -0700 

Revision: 12548
Author:   [email protected]
Date:     Wed Sep 19 05:48:49 2012
Log:      Fixed minus zero test (fixes v8:2133).

BUG=v8:2133

Review URL: https://chromiumcodereview.appspot.com/10937013
http://code.google.com/p/v8/source/detail?r=12548

Added:
 /branches/bleeding_edge/test/mjsunit/deopt-minus-zero.js
Modified:
 /branches/bleeding_edge/src/ia32/assembler-ia32.cc
 /branches/bleeding_edge/src/ia32/assembler-ia32.h
 /branches/bleeding_edge/src/ia32/code-stubs-ia32.cc
 /branches/bleeding_edge/src/ia32/disasm-ia32.cc

=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/deopt-minus-zero.js Wed Sep 19 05:48:49 2012 
@@ -0,0 +1,56 @@
+// Copyright 2012 the V8 project authors. All rights reserved.
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+//       notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+//       copyright notice, this list of conditions and the following
+//       disclaimer in the documentation and/or other materials provided
+//       with the distribution.
+//     * Neither the name of Google Inc. nor the names of its
+//       contributors may be used to endorse or promote products derived
+//       from this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+// Flags: --allow-natives-syntax --expose-gc
+
+/**
+ * The possible optimization states of a function. Must be in sync with the
+ * return values of Runtime_GetOptimizationStatus() in runtime.cc!
+ */
+var OptimizationState = {
+    YES: 1,
+    NO: 2,
+    ALWAYS: 3,
+    NEVER: 4
+};
+
+function mul (a, b) {
+  return a * b;
+}
+
+mul(-1, -1);
+mul(0x80000001|0, -1);
+mul(0x80000001|0, -1);
+%OptimizeFunctionOnNextCall(mul);
+mul(0, -1);
+%OptimizeFunctionOnNextCall(mul);
+mul(0, -1);
+
+var raw_optimized = %GetOptimizationStatus(mul);
+assertFalse(raw_optimized == OptimizationState.NO);
+gc();
+
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.cc Wed Aug 22 07:27:11 2012 +++ /branches/bleeding_edge/src/ia32/assembler-ia32.cc Wed Sep 19 05:48:49 2012 
@@ -2103,6 +2103,16 @@
   EMIT(0x50);
   emit_sse_operand(dst, src);
 }
+
+
+void Assembler::pcmpeqd(XMMRegister dst, XMMRegister src) {
+  ASSERT(CpuFeatures::IsEnabled(SSE2));
+  EnsureSpace ensure_space(this);
+  EMIT(0x66);
+  EMIT(0x0F);
+  EMIT(0x76);
+  emit_sse_operand(dst, src);
+}


 void Assembler::cmpltsd(XMMRegister dst, XMMRegister src) {
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.h Wed Aug 22 07:27:11 2012 +++ /branches/bleeding_edge/src/ia32/assembler-ia32.h Wed Sep 19 05:48:49 2012 
@@ -1016,6 +1016,7 @@
   void movmskpd(Register dst, XMMRegister src);

   void cmpltsd(XMMRegister dst, XMMRegister src);
+  void pcmpeqd(XMMRegister dst, XMMRegister src);

   void movaps(XMMRegister dst, XMMRegister src);

=======================================
--- /branches/bleeding_edge/src/ia32/code-stubs-ia32.cc Tue Sep 18 01:04:31 2012 +++ /branches/bleeding_edge/src/ia32/code-stubs-ia32.cc Wed Sep 19 05:48:49 2012 
@@ -1793,9 +1793,10 @@
           if (result_type_ <= BinaryOpIC::INT32) {
             __ cvttsd2si(ecx, Operand(xmm0));
             __ cvtsi2sd(xmm2, ecx);
-            __ ucomisd(xmm0, xmm2);
-            __ j(not_zero, &not_int32);
-            __ j(carry, &not_int32);
+            __ pcmpeqd(xmm2, xmm0);
+            __ movmskpd(ecx, xmm2);
+            __ test(ecx, Immediate(1));
+            __ j(zero, &not_int32);
           }
           GenerateHeapResultAllocation(masm, &call_runtime);
           __ movdbl(FieldOperand(eax, HeapNumber::kValueOffset), xmm0);
=======================================
--- /branches/bleeding_edge/src/ia32/disasm-ia32.cc     Wed Aug 22 07:27:11 2012
+++ /branches/bleeding_edge/src/ia32/disasm-ia32.cc     Wed Sep 19 05:48:49 2012
@@ -1305,6 +1305,14 @@
                            NameOfXMMRegister(rm),
                            static_cast<int>(imm8));
             data += 2;
+          } else if (*data == 0x76) {
+            data++;
+            int mod, regop, rm;
+            get_modrm(*data, &mod, &regop, &rm);
+            AppendToBuffer("pcmpeqd %s,%s",
+                           NameOfXMMRegister(regop),
+                           NameOfXMMRegister(rm));
+            data++;
           } else if (*data == 0x90) {
             data++;
             AppendToBuffer("nop");  // 2 byte nop.

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to