Revision: 12558
Author:   [email protected]
Date:     Wed Sep 19 08:39:00 2012
Log:      Merged r12478 into 3.12 branch.

Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM.

BUG=v8:2314

[email protected]

Review URL: https://chromiumcodereview.appspot.com/10937031
http://code.google.com/p/v8/source/detail?r=12558

Modified:
 /branches/3.12/src/arm/lithium-codegen-arm.cc
 /branches/3.12/src/version.cc

=======================================
--- /branches/3.12/src/arm/lithium-codegen-arm.cc       Wed Aug  1 04:14:42 2012
+++ /branches/3.12/src/arm/lithium-codegen-arm.cc       Wed Sep 19 08:39:00 2012
@@ -2397,12 +2397,18 @@
   Register temp = ToRegister(instr->TempAt(0));
   ASSERT(temp.is(r4));
   __ LoadHeapObject(InstanceofStub::right(), instr->function());
-  static const int kAdditionalDelta = 4;
+  static const int kAdditionalDelta = 5;
int delta = masm_->InstructionsGeneratedSince(map_check) + kAdditionalDelta;
   Label before_push_delta;
   __ bind(&before_push_delta);
   __ BlockConstPoolFor(kAdditionalDelta);
   __ mov(temp, Operand(delta * kPointerSize));
+ // The mov above can generate one or two instructions. The delta was computed + // for two instructions, so we need to pad here in case of one instruction.
+  if (masm_->InstructionsGeneratedSince(&before_push_delta) != 2) {
+    ASSERT_EQ(1, masm_->InstructionsGeneratedSince(&before_push_delta));
+    __ nop();
+  }
   __ StoreToSafepointRegisterSlot(temp, temp);
   CallCodeGeneric(stub.GetCode(),
                   RelocInfo::CODE_TARGET,
=======================================
--- /branches/3.12/src/version.cc       Mon Sep 17 01:14:05 2012
+++ /branches/3.12/src/version.cc       Wed Sep 19 08:39:00 2012
@@ -35,7 +35,7 @@
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     12
 #define BUILD_NUMBER      19
-#define PATCH_LEVEL       10
+#define PATCH_LEVEL       11
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)
 #define IS_CANDIDATE_VERSION 0

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to