Two general questions on the incremental marking part of this CL:
1) Would it be possible to share the code between incremental and non-incremental marking? 2) Would it be possible to use static visitors for incremental marking? https://codereview.chromium.org/10959011/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/10959011/diff/1/src/mark-compact.cc#newcode2181 src/mark-compact.cc:2181: } while (!marking_deque_.IsEmpty()); Instead of adding yet another loop we could just reuse the outer one that was added for the WeakMaps fix-point iteration. https://codereview.chromium.org/10959011/diff/1/src/mark-compact.cc#newcode2190 src/mark-compact.cc:2190: void MarkCompactCollector::FillMarkingDequeFromLargePostponedArrays() { How about naming this "ProcessLargePostponedArrays()" https://codereview.chromium.org/10959011/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
