LGTM (with one comment), if it doesn't regress Splay, Spinning Balls or any other GC benchmark.
https://codereview.chromium.org/10974003/diff/10003/src/incremental-marking.cc File src/incremental-marking.cc (right): https://codereview.chromium.org/10974003/diff/10003/src/incremental-marking.cc#newcode791 src/incremental-marking.cc:791: write_barriers_invoked_since_last_step_ < kIncrementalMarkingThreshold) { Even if the two thresholds we are comparing against happen to have the same value, I think we should still use two different constants here (one for allocation and one for WB counts). https://codereview.chromium.org/10974003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
