Status: New
Owner: ----

New issue 2348 by [email protected]: C4100 warnings when compiling using VS2005 SP1
http://code.google.com/p/v8/issues/detail?id=2348

The v8.h header file is giving C4100 unreferenced parameter warnings.

To fix the warnings, I had to add UNREFERENCED_PARAMETER() macros to the following methods to get a clean compile using VS2005 SP1:

  virtual v8::Handle<v8::FunctionTemplate>
GetNativeFunction(v8::Handle<v8::String> name) { UNREFERENCED_PARAMETER(name);
    return v8::Handle<v8::FunctionTemplate>();
  }

virtual void VisitExternalString(Handle<String> string) { UNREFERENCED_PARAMETER(string); }

virtual WriteResult WriteHeapStatsChunk(HeapStatsUpdate* data, int count) {
      UNREFERENCED_PARAMETER(data);
      UNREFERENCED_PARAMETER(count);
    return kAbort;
  };

static inline bool CanCastToHeapObject(void* o) { UNREFERENCED_PARAMETER(o); return false; } static inline bool CanCastToHeapObject(Context* o) { UNREFERENCED_PARAMETER(o); return true; } static inline bool CanCastToHeapObject(String* o) { UNREFERENCED_PARAMETER(o); return true; } static inline bool CanCastToHeapObject(Object* o) { UNREFERENCED_PARAMETER(o); return true; } static inline bool CanCastToHeapObject(Message* o) { UNREFERENCED_PARAMETER(o); return true; } static inline bool CanCastToHeapObject(StackTrace* o) { UNREFERENCED_PARAMETER(o); return true; } static inline bool CanCastToHeapObject(StackFrame* o) { UNREFERENCED_PARAMETER(o); return true; }

Attached is my changed v8.h header file.

Attachments:
        v8.h  148 KB

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to