LGTM with the comments below. I'll fix both and land this.
http://codereview.chromium.org/10990070/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/10990070/diff/1/build/common.gypi#newcode307 build/common.gypi:307: [ 'OS!="android" or clang==1', { |clang| is not defined when building outside of Chromium, so GYP will produce a stacktrace instead of Makefiles. http://codereview.chromium.org/10990070/diff/1/build/common.gypi#newcode308 build/common.gypi:308: 'cflags': [ '<(m32flag)' ], nit: indentation http://codereview.chromium.org/10990070/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
