Reviewers: Michael Starzinger,

Message:
PTAL.

Description:
test runner: fix wildcard handling in test status files


Please review this at https://codereview.chromium.org/10986086/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M tools/testrunner/local/testsuite.py


Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py b/tools/testrunner/local/testsuite.py index 744959d36daf84d074c0df5bf426f35af6a0d419..de5cddd11501c5cf0a3f2261aeb2c19f59995d32 100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -96,14 +96,17 @@ class TestSuite(object):
         if statusfile.DoSkip(outcomes):
           continue  # Don't add skipped tests to |filtered|.
       if len(self.wildcards) != 0:
+        skip = False
         for rule in self.wildcards:
           assert rule[-1] == '*'
           if testname.startswith(rule[:-1]):
             used_rules.add(rule)
             outcomes = self.wildcards[rule]
-            if statusfile.DoSkip(outcomes):
-              continue
             t.outcomes = outcomes
+            if statusfile.DoSkip(outcomes):
+              skip = True
+              break  # "for rule in self.wildcards"
+        if skip: continue  # "for t in self.tests"
       filtered.append(t)
     self.tests = filtered



--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to