Reviewers: Michael Starzinger,
Message:
PTAL.
Description:
Test runner: fix empty patches; better error message for missing test files;
correct .gitignore entry for message.status2
Please review this at https://codereview.chromium.org/11035004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M .gitignore
M tools/testrunner/network/endpoint.py
M tools/testrunner/server/work_handler.py
Index: .gitignore
diff --git a/.gitignore b/.gitignore
index
6aae4db0b18a4b7410595d831bdf0fa1db024516..c39f642fe3b051cb2c3cc29e525bcbf264bf0fd2
100644
--- a/.gitignore
+++ b/.gitignore
@@ -29,7 +29,7 @@ shell_g
/out/
/test/cctest/cctest.status2
/test/es5conform/data
-/test/messages/messages.status2
+/test/message/message.status2
/test/mjsunit/mjsunit.status2
/test/mozilla/CHECKED_OUT_VERSION
/test/mozilla/data
Index: tools/testrunner/network/endpoint.py
diff --git a/tools/testrunner/network/endpoint.py
b/tools/testrunner/network/endpoint.py
index
25547c2f15e7f0c87a719bf0a61c80d3347c838e..8350feee5984051ad8c7019a647431bf0d515bac
100644
--- a/tools/testrunner/network/endpoint.py
+++ b/tools/testrunner/network/endpoint.py
@@ -108,7 +108,15 @@ def Execute(workspace, ctx, tests, sock, server):
progress_indicator = EndpointProgress(sock, server, ctx)
runner = execution.Runner(suites, progress_indicator, ctx)
- runner.Run(server.jobs)
+ try:
+ runner.Run(server.jobs)
+ except IOError, e:
+ if e.errno == 2:
+ message = ("File not found: %s, maybe you forgot to 'git add' it?" %
+ e.filename)
+ else:
+ message = "%s" % e
+ compression.Send([-1, message], sock)
progress_indicator.HasRun(None) # Sentinel to signal the end.
progress_indicator.sender_lock.acquire() # Released when sending is
done.
progress_indicator.sender_lock.release()
Index: tools/testrunner/server/work_handler.py
diff --git a/tools/testrunner/server/work_handler.py
b/tools/testrunner/server/work_handler.py
index
9e61af8227adaff2c1c314de77f1d0a3131ef44d..80f01781ebb37427c20ac4210dfe3638f15ddcfb
100644
--- a/tools/testrunner/server/work_handler.py
+++ b/tools/testrunner/server/work_handler.py
@@ -128,6 +128,7 @@ class WorkHandler(SocketServer.BaseRequestHandler):
return True
def _ApplyPatch(self, patch):
+ if not patch: return True # Just skip if the patch is empty.
patchfilename = "_dtest_incoming_patch.patch"
with open(patchfilename, "w") as f:
f.write(patch)
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
